cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9238) URL fields in database are to small. Cause malformed URLs
Date Thu, 14 Jan 2016 14:27:39 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098161#comment-15098161
] 

ASF GitHub Bot commented on CLOUDSTACK-9238:
--------------------------------------------

GitHub user wido opened a pull request:

    https://github.com/apache/cloudstack/pull/1341

    CLOUDSTACK-9238: Increase URL fields to 2048 charachters from 255

    255 characters is to small for various URLs like S3 pre-signed URLs.
    
    This causes one or more characters to be chopped of the end of the URL
    and this renders them useless.
    
    Internally in the code all URLs are passed as Strings and they are not
    sized limited. This was purely in the database.
    
    Other URL fields in the database were already 2048 characters.
    
    This limit was introduced in the 4.1 to 4.2 upgrade when Object storage
    like S3 and Swift was introduced in CloudStack for Secondary Storage.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wido/cloudstack CLOUDSTACK-9238

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1341
    
----
commit a171bbc96dc4c44734d6c14265347f9db791a0cb
Author: Wido den Hollander <wido@widodh.nl>
Date:   2016-01-14T13:06:04Z

    CLOUDSTACK-9238: Increase URL fields to 2048 charachters from 255
    
    255 characters is to small for various URLs like S3 pre-signed URLs.
    
    This causes one or more characters to be chopped of the end of the URL
    and this renders them useless.
    
    Internally in the code all URLs are passed as Strings and they are not
    sized limited. This was purely in the database.
    
    Other URL fields in the database were already 2048 characters.
    
    This limit was introduced in the 4.1 to 4.2 upgrade when Object storage
    like S3 and Swift was introduced in CloudStack for Secondary Storage.

----


> URL fields in database are to small. Cause malformed URLs
> ---------------------------------------------------------
>
>                 Key: CLOUDSTACK-9238
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9238
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0, 4.7.0, 4.8.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>              Labels: s3, template, templates, url, urls
>             Fix For: 4.8.0
>
>
> In for example the 'volume_store_ref' table the 'download_url' field is a VARCHAR(255).
> This is to short for URLs. Same goes for the 'object_datastore_ref' table and the 'url'
field.
> With pre-signed S3 URLs this will cause issues.
> The fix would be to change the database fields to a VARCHAR(2048). No code-change is
required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message