cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9204) Delete static route fails when it's already gone
Date Sat, 16 Jan 2016 18:44:39 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103335#comment-15103335
] 

ASF subversion and git services commented on CLOUDSTACK-9204:
-------------------------------------------------------------

Commit b4ebfb640e4514e45190846965b4a6a77bb3ae8a in cloudstack's branch refs/heads/4.7 from
[~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b4ebfb6 ]

Merge pull request #1298 from remibergsma/staticroute_delete_47

CLOUDSTACK-9204 Do not error when staticroute is already goneWhen deleting a static route
fails because it isn't there any more (KeyError), it should succeed instead.

Error seen:
```
[INFO] Processing JSON file static_routes.json.1451560145
Traceback (most recent call last):
File "/opt/cloud/bin/update_config.py", line 140, in <module>
process_file()
File "/opt/cloud/bin/update_config.py", line 52, in process_file
qf.load(None)
File "/opt/cloud/bin/merge.py", line 258, in load
proc = updateDataBag(self)
File "/opt/cloud/bin/merge.py", line 91, in _init_
self.process()
File "/opt/cloud/bin/merge.py", line 131, in process
dbag = self.process_staticroutes(self.db.getDataBag())
File "/opt/cloud/bin/merge.py", line 179, in process_staticroutes
return cs_staticroutes.merge(dbag, self.qFile.data)
File "/opt/cloud/bin/cs_staticroutes.py", line 26, in merge
del dbag[key]
KeyError: u'192.168.0.3'
```

* pr/1298:
  CLOUDSTACK-9204 Do not error when staticroute is already gone

Signed-off-by: Remi Bergsma <github@remi.nl>


> Delete static route fails when it's already gone
> ------------------------------------------------
>
>                 Key: CLOUDSTACK-9204
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9204
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: SystemVM
>    Affects Versions: 4.7.0
>            Reporter: Remi Bergsma
>            Assignee: Remi Bergsma
>            Priority: Critical
>             Fix For: 4.7.1
>
>
> When you try to delete a static route, this fails when it's no longer there on the router
(not sure why that happens).
> Error seen:
> [INFO] update_config.py :: Processing incoming file => static_routes.json.1451560145
> [INFO] Processing JSON file static_routes.json.1451560145
> Traceback (most recent call last):
>   File "/opt/cloud/bin/update_config.py", line 140, in <module>
>     process_file()
>   File "/opt/cloud/bin/update_config.py", line 52, in process_file
>     qf.load(None)
>   File "/opt/cloud/bin/merge.py", line 258, in load
>     proc = updateDataBag(self)
>   File "/opt/cloud/bin/merge.py", line 91, in __init__
>     self.process()
>   File "/opt/cloud/bin/merge.py", line 131, in process
>     dbag = self.process_staticroutes(self.db.getDataBag())
>   File "/opt/cloud/bin/merge.py", line 179, in process_staticroutes
>     return cs_staticroutes.merge(dbag, self.qFile.data)
>   File "/opt/cloud/bin/cs_staticroutes.py", line 26, in merge
>     del dbag[key]
> KeyError: u'192.168.0.3'
> When deleting fails because it isn't there any more, it should succeed ;-)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message