cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9198) VR gets created in the disabled POD
Date Sun, 10 Jan 2016 00:27:39 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090832#comment-15090832
] 

ASF GitHub Bot commented on CLOUDSTACK-9198:
--------------------------------------------

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1278#discussion_r49269955
  
    --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
    @@ -509,7 +511,9 @@ public DomainRouterVO deployRouter(final RouterDeploymentDefinition
routerDeploy
     
                 if (startRouter) {
                     try {
    -                    router = startVirtualRouter(router, _accountMgr.getSystemUser(),
_accountMgr.getSystemAccount(), routerDeploymentDefinition.getParams());
    +                    final Account caller = CallContext.current().getCallingAccount();
    --- End diff --
    
    @anshul1886 could you please create a method for the new lines? As it is a duplicate code,
a method keeps the code clean and helps in future works (especially if well documented).


> VR gets created in the disabled POD
> -----------------------------------
>
>                 Key: CLOUDSTACK-9198
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9198
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
>
> VR gets created in the disabled POD



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message