cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9132) API createVolume takes empty string for name parameter
Date Tue, 12 Jan 2016 19:11:40 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094549#comment-15094549
] 

ASF GitHub Bot commented on CLOUDSTACK-9132:
--------------------------------------------

Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1319#discussion_r49498772
  
    --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
    @@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus status) {
             });
         }
     
    +    /**
    +     * Retrieves the volume name from CreateVolumeCmd object.
    +     *
    +     * If the retrieved volume name is null, empty or blank, then A random name
    +     * will be generated using getRandomVolumeName method.
    +     *
    +     * @param cmd
    +     * @return Either the retrieved name or a random name.
    +     */
    +    public String getVolumeNameFromCommand(CreateVolumeCmd cmd) {
    +        String userSpecifiedName = cmd.getVolumeName();
    +
    +        if (org.apache.commons.lang.StringUtils.isBlank(userSpecifiedName)) {
    --- End diff --
    
    Cool...then it all looks good to me.
    
    Unfortunately, at the time being, I have my dev system in a state that would make it difficult
and time consuming for me to test this.
    
    If you do require a tester, please let me know. It might take a few days, though, before
I finish up my current project and can put this code on my system.
    
    Thanks


> API createVolume takes empty string for name parameter
> ------------------------------------------------------
>
>                 Key: CLOUDSTACK-9132
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9132
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Nitin Kumar Maharana
>
> Steps to Reproduce:
> ================
> Create a volume using createVolume API where parameter name is empty.
> It creates a volume with empty name.
> But the name parameter is mandatory.(Issue)
> Expected Behaviour:
> ================
> It shouldn't create a volume with an empty name. Error should be returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message