cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8958) add dedicated ips to domain
Date Sat, 23 Jan 2016 05:36:39 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113583#comment-15113583
] 

ASF GitHub Bot commented on CLOUDSTACK-8958:
--------------------------------------------

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1357#discussion_r50616271
  
    --- Diff: server/test/com/cloud/vpc/MockConfigurationManagerImpl.java ---
    @@ -456,6 +456,15 @@ public void createDefaultSystemNetworks(long zoneId) throws ConcurrentOperationE
         }
     
         /* (non-Javadoc)
    +     * @see com.cloud.configuration.ConfigurationManager#deleteDomainSpecificVirtualRanges(long)
    +     */
    +    @Override
    --- End diff --
    
    @ustcweizhou The method "com.cloud.configuration.ConfigurationManager.deleteDomainSpecificVirtualRanges(long)"
does not exist. Could you please alter this?
    
    I am wondering, why this is a "non-Javadoc"? In my point of view, it could be a Javadoc
block.
    
    There is another point citing an inexistent method (at "releaseAccountSpecificVirtualRanges"
method which is referring to "com.cloud.configuration.ConfigurationManager.deleteAccountSpecificVirtualRanges(long)").
Although this comment is out of this PR scope, I think that it would be nice to take the opportunity.


> add dedicated ips to domain
> ---------------------------
>
>                 Key: CLOUDSTACK-8958
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8958
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>
> add dedicated ips to domain 
> ips are dedicated to Account for now, so other customers and projects in the same domain
will use the system ip. this is not what we need.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message