Return-Path: 
 <issues-return-65602-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-issues-archive@www.apache.org
Delivered-To: apmail-cloudstack-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B906718035
	for <apmail-cloudstack-issues-archive@www.apache.org>;
 Sun,  6 Dec 2015 15:43:11 +0000 (UTC)
Received: (qmail 89641 invoked by uid 500); 6 Dec 2015 15:43:11 -0000
Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org
Received: (qmail 89523 invoked by uid 500); 6 Dec 2015 15:43:11 -0000
Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:issues@cloudstack.apache.org>
List-Id: <issues.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list issues@cloudstack.apache.org
Received: (qmail 89321 invoked by uid 500); 6 Dec 2015 15:43:11 -0000
Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org
Received: (qmail 89271 invoked by uid 99); 6 Dec 2015 15:43:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Dec 2015 15:43:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 064352C1F5D
	for <cloudstack-issues@incubator.apache.org>;
 Sun,  6 Dec 2015 15:43:11 +0000 (UTC)
Date: Sun, 6 Dec 2015 15:43:11 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12918912.1449215923000.283157.1449416591022@Atlassian.JIRA>
In-Reply-To: <JIRA.12918912.1449215923000@Atlassian.JIRA>
References: <JIRA.12918912.1449215923000@Atlassian.JIRA>
 <JIRA.12918912.1449215923429@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9106) As a Developer I want the
 Redundant VPC private gateway feature fixed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043929#comment-15043929 ] 

ASF GitHub Bot commented on CLOUDSTACK-9106:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1179#discussion_r46771839
  
    --- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
    @@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final Long nspId, final Type providerTyp
     
         @Override
         public boolean applyPFRules(final Network network, final List<PortForwardingRule> rules) throws ResourceUnavailableException {
    +        boolean result = false;
             if (canHandle(network, Service.PortForwarding)) {
                 final List<DomainRouterVO> routers = _routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
                 if (routers == null || routers.isEmpty()) {
                     s_logger.debug("Virtual router elemnt doesn't need to apply firewall rules on the backend; virtual " + "router doesn't exist in the network " + network.getId());
    -                return true;
    +                result = true;
    --- End diff --
    
    I agree with your consideration and I am not forcing you to change to win my lgtm. I just want to make sure we discuss the consideration here for posterity and change only if a simple good alternative comes up.
    
    I noticed line 874 and wondered about this and the &= thingy upstairs. I would use a combination of first trying all of them and then throw the exception if any of them failed


> As a Developer I want the Redundant VPC private gateway feature fixed
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9106
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9106
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.7.0
>
>
> Bug in BasicNetworkTopology.applyRules() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)