Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C637183FD for ; Sun, 6 Dec 2015 18:08:11 +0000 (UTC) Received: (qmail 36501 invoked by uid 500); 6 Dec 2015 18:08:11 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 36457 invoked by uid 500); 6 Dec 2015 18:08:11 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 36433 invoked by uid 500); 6 Dec 2015 18:08:11 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 36422 invoked by uid 99); 6 Dec 2015 18:08:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Dec 2015 18:08:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F1E182C1F57 for ; Sun, 6 Dec 2015 18:08:10 +0000 (UTC) Date: Sun, 6 Dec 2015 18:08:10 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043987#comment-15043987 ] ASF GitHub Bot commented on CLOUDSTACK-9025: -------------------------------------------- Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1176#discussion_r46773579 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java --- @@ -185,7 +185,8 @@ public boolean trackVmHostChange() { DataTO srcData = cpyCommand.getSrcTO(); DataTO destData = cpyCommand.getDestTO(); - if (srcData.getObjectType() == DataObjectType.SNAPSHOT && destData.getObjectType() == DataObjectType.TEMPLATE) { + if (srcData.getHypervisorType() == HypervisorType.XenServer && srcData.getObjectType() == DataObjectType.SNAPSHOT && --- End diff -- @anshul1886 I looked it up. @bhaisaab @ustcweizhou Anshul is right about the equals versus ==, for readability it makes sense to leave this as is. from 8.9 in the language specs: Because there is only one instance of each enum constant, it is permitted to use the == operator in place of the equals method when comparing two object references if it is known that at least one of them refers to an enum constant. > Unable to deploy VM instance from template if template spin from linked clone snapshot > -------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-9025 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: XenServer > Affects Versions: 4.5.2 > Environment: XenServer 6.5 > Reporter: Anshul Gangwar > Assignee: Anshul Gangwar > Priority: Critical > > As default, CloudStack create linked clone snapshot for VM instance . When we take a snapshot for the VM, and create a template based on such snapshot, CloudStack only download incremental VHD as template file, as a result, the VM instance fail to deploy as it is incomplete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)