cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9174) Quota Service: When a account/user is deleted with low quota, quota service still tries to alert the user resulting in NPE
Date Thu, 17 Dec 2015 17:07:46 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062345#comment-15062345
] 

ASF GitHub Bot commented on CLOUDSTACK-9174:
--------------------------------------------

Github user resmo commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1254#discussion_r47931786
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java
---
    @@ -59,7 +59,7 @@ public QuotaSummaryCmd() {
         public void execute() {
             Account caller = CallContext.current().getCallingAccount();
             List<QuotaSummaryResponse> responses;
    -        if (caller.getAccountId() <= 2) { //non root admin or system
    +        if (caller.getAccountId() <= 2) { // root admin or system
    --- End diff --
    
    to assume that an account <=2 has root admin privileges is just naive. There must be
a solid way to do this. Just my 2 cents..


> Quota Service: When a account/user is deleted with low quota, quota service still tries
to alert the user resulting in NPE
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9174
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9174
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.7.0
>            Reporter: Abhinandan Prateek
>            Assignee: Abhinandan Prateek
>            Priority: Critical
>             Fix For: 4.8.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message