cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9161) Quota Service: fix marvin test
Date Mon, 14 Dec 2015 11:01:46 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055827#comment-15055827
] 

ASF GitHub Bot commented on CLOUDSTACK-9161:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1240#discussion_r47484456
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
    @@ -186,7 +186,7 @@ public int compare(QuotaBalanceVO o1, QuotaBalanceVO o2) {
             //check that there is at least one balance entry
             for (Iterator<QuotaBalanceVO> it = quotaBalance.iterator(); it.hasNext();)
{
                 QuotaBalanceVO entry = it.next();
    -            if (entry.getCreditsId() > 0) {
    +            if (entry.getCreditsId() == 0) {
    --- End diff --
    
    BTW i would factor this out as a boolean checker method


> Quota Service: fix marvin test
> ------------------------------
>
>                 Key: CLOUDSTACK-9161
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9161
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.7.0
>            Reporter: Abhinandan Prateek
>            Assignee: Abhinandan Prateek
>            Priority: Critical
>             Fix For: 4.7.0
>
>
> the two tests in test_quota.py marvin tests are failing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message