cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9132) API createVolume takes empty string for name parameter
Date Mon, 14 Dec 2015 11:47:46 GMT


ASF GitHub Bot commented on CLOUDSTACK-9132:

Github user rafaelweingartner commented on the pull request:
    Hi @nitin-maharana I agree with @DaanHoogland, we should maintain backward compatibility.
I almost liked you code, I would just suggest you extracting it to a method such as getVolumeName
or getCreateVolumeNameIfNeeded (sorry for the lack of creativity, today I am out of inspiration).
    After you extracted the code to a method, you should be able to write at least two test
cases to make sure it is working as expected. 

> API createVolume takes empty string for name parameter
> ------------------------------------------------------
>                 Key: CLOUDSTACK-9132
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Nitin Kumar Maharana
> Steps to Reproduce:
> ================
> Create a volume using createVolume API where parameter name is empty.
> It creates a volume with empty name.
> But the name parameter is mandatory.(Issue)
> Expected Behaviour:
> ================
> It shouldn't create a volume with an empty name. Error should be returned.

This message was sent by Atlassian JIRA

View raw message