cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9132) API createVolume takes empty string for name parameter
Date Mon, 28 Dec 2015 04:44:49 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072413#comment-15072413
] 

ASF GitHub Bot commented on CLOUDSTACK-9132:
--------------------------------------------

Github user nitin-maharana commented on the pull request:

    https://github.com/apache/cloudstack/pull/1273#issuecomment-167484496
  
    @rafaelweingartner : Thanks for reviewing the change.
    
    The reason to close the old PR is because it was merging with branch 4.6.
    I started this PR a long days back when everything from 4.6 being merged with master.
    But now I dont know the same is happening or not.
    
    I saw most of the recent PRs are created with merging request to master. So, I opened
a new PR with master. But I have given a reference to my old PR. So that reviewers can see
the conversation.
    
    About the code change, if we will make "required=true", there will be a mismatch in logic
of UI and API. In UI, the field is optional. I will modify the comments section. Thanks for
suggesting.



> API createVolume takes empty string for name parameter
> ------------------------------------------------------
>
>                 Key: CLOUDSTACK-9132
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9132
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Nitin Kumar Maharana
>
> Steps to Reproduce:
> ================
> Create a volume using createVolume API where parameter name is empty.
> It creates a volume with empty name.
> But the name parameter is mandatory.(Issue)
> Expected Behaviour:
> ================
> It shouldn't create a volume with an empty name. Error should be returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message