cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9132) API createVolume takes empty string for name parameter
Date Mon, 14 Dec 2015 11:34:46 GMT


ASF GitHub Bot commented on CLOUDSTACK-9132:

Github user DaanHoogland commented on the pull request:
    I don't agree, for two reasons
    1. making the field required constitutes a backwards incompatibility of the API
    2. we should use as much reasonable defaults as posible as to not burdon the user with
decision they don't strictly have to make.
    I do agree with the present implementation as can be seen in the diff at this moment:
    -        if (userSpecifiedName == null) {
    +        if (userSpecifiedName == null || userSpecifiedName.isEmpty()) {
    Though the screenshots are not real tests I can live with them for this change: LGTM

> API createVolume takes empty string for name parameter
> ------------------------------------------------------
>                 Key: CLOUDSTACK-9132
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Nitin Kumar Maharana
> Steps to Reproduce:
> ================
> Create a volume using createVolume API where parameter name is empty.
> It creates a volume with empty name.
> But the name parameter is mandatory.(Issue)
> Expected Behaviour:
> ================
> It shouldn't create a volume with an empty name. Error should be returned.

This message was sent by Atlassian JIRA

View raw message