cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9127) Missing PV-bootloader-args for "SUSE Linux Enterprise Server 10 SP2 and SP3"
Date Thu, 10 Dec 2015 10:55:10 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050582#comment-15050582
] 

ASF GitHub Bot commented on CLOUDSTACK-9127:
--------------------------------------------

Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1196#discussion_r47212450
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
    @@ -236,4 +236,15 @@ public static String getProductVersion(final Host.Record record)
{
             }
             return prodVersion;
         }
    +
    +    public static String getPVbootloaderArgs(String guestOS) {
    +        if (guestOS.startsWith("SUSE Linux Enterprise Server")) {
    +            if (guestOS.contains("64-bit")) {
    +                return "--kernel /boot/vmlinuz-xen --ramdisk /boot/initrd-xen";
    +            } else if (guestOS.contains("32-bit")) {
    +                return "--kernel /boot/vmlinuz-xenpae --ramdisk /boot/initrd-xenpae";
    +            }
    +        }
    +        return "";
    +    }
    --- End diff --
    
    Change looks good and simple. Could you please add an unit test to cover the new method?
    
    Cheers,
    Wilder


> Missing PV-bootloader-args for "SUSE Linux Enterprise Server 10 SP2 and SP3"
> ----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9127
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9127
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: sudharma jain
>
> STOP-START of SUSE Linux VMs fail, as PV-bootloader-args are missing during the start
command.
> DESCRIPTION
> =======
> Repro steps
> 1. Upload Suse ISO 
> 2. Create a VM with this ISO, and install it.
> 3. Detach ISO from the VM. 
> 4. Reboot the VM, :>>>> This will work fine, as the pv-bootloader-args are
not missing during reboot.
> 5.Stop the VM from CCP(VM will get destroyed in Xencenter)
> 6. Start the same VM from CCP , it will try to start but will fail with below error



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message