cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9106) As a Developer I want the Redundant VPC private gateway feature fixed
Date Sun, 06 Dec 2015 12:33:11 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043853#comment-15043853
] 

ASF GitHub Bot commented on CLOUDSTACK-9106:
--------------------------------------------

Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1179#discussion_r46769789
  
    --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
    @@ -488,50 +494,54 @@ public boolean applyPFRules(final Network network, final List<PortForwardingRule
                 return true;
             }
     
    -        DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
    -        NetworkTopology networkTopology = _networkTopologyContext.retrieveNetworkTopology(dcVO);
    -
    -        return networkTopology.applyFirewallRules(network, rules, routers);
    +        final DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
    +        final NetworkTopology networkTopology = _networkTopologyContext.retrieveNetworkTopology(dcVO);
    +        for (final DomainRouterVO domainRouterVO : routers) {
    +            result = networkTopology.applyFirewallRules(network, rules, domainRouterVO);
    --- End diff --
    
    Yep... I know. That's what I said when you first mentioned it. I will change it now, but
we have to revisit many places in the Java side as well, and not only the classes I changed,
but the VpcManagerImpl.java, for instance.


> As a Developer I want the Redundant VPC private gateway feature fixed
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9106
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9106
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.7.0
>
>
> Bug in BasicNetworkTopology.applyRules() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message