cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9106) As a Developer I want the Redundant VPC private gateway feature fixed
Date Sat, 05 Dec 2015 19:10:11 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043452#comment-15043452
] 

ASF GitHub Bot commented on CLOUDSTACK-9106:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1179#discussion_r46761808
  
    --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
    @@ -445,13 +446,14 @@ public boolean applyIps(final Network network,
                     return true;
                 }
     
    -            DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
    -            NetworkTopology networkTopology = _networkTopologyContext.retrieveNetworkTopology(dcVO);
    +            final DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
    +            final NetworkTopology networkTopology = _networkTopologyContext.retrieveNetworkTopology(dcVO);
     
    -            return networkTopology.associatePublicIP(network, ipAddress, routers);
    -        } else {
    -            return false;
    +            for (final DomainRouterVO domainRouterVO : routers) {
    +                result =  networkTopology.associatePublicIP(network, ipAddress, domainRouterVO);
    --- End diff --
    
    will we forget all intermediate results and only return the last one?


> As a Developer I want the Redundant VPC private gateway feature fixed
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9106
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9106
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.7.0
>
>
> Bug in BasicNetworkTopology.applyRules() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message