cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot
Date Sun, 06 Dec 2015 18:08:10 GMT


ASF GitHub Bot commented on CLOUDSTACK-9025:

Github user DaanHoogland commented on a diff in the pull request:
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/ ---
    @@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
                 DataTO srcData = cpyCommand.getSrcTO();
                 DataTO destData = cpyCommand.getDestTO();
    -            if (srcData.getObjectType() == DataObjectType.SNAPSHOT && destData.getObjectType()
== DataObjectType.TEMPLATE) {
    +            if (srcData.getHypervisorType() == HypervisorType.XenServer && srcData.getObjectType()
== DataObjectType.SNAPSHOT &&
    --- End diff --
    @anshul1886  I looked it up. @bhaisaab @ustcweizhou Anshul is right about the equals versus
==, for readability it makes sense to leave this as is. from 8.9 in the language specs:
    Because there is only one instance of each enum constant, it is permitted to use the ==
operator in place of the equals method when comparing two object references if it is known
that at least one of them refers to an enum constant.

> Unable to deploy VM instance from template if template spin from linked clone snapshot
> --------------------------------------------------------------------------------------
>                 Key: CLOUDSTACK-9025
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: XenServer
>    Affects Versions: 4.5.2
>         Environment: XenServer 6.5
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
>            Priority: Critical
> As default, CloudStack create linked clone snapshot for VM instance . When we take a
snapshot for the VM, and create a template based on such snapshot, CloudStack only download
incremental VHD as template file, as a result, the VM instance fail to deploy as it is incomplete.

This message was sent by Atlassian JIRA

View raw message