Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 26 Nov 2015 09:23:11 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12916364.1448520894000.201254.1448529791193@Atlassian.JIRA>
In-Reply-To: <JIRA.12916364.1448520894000@Atlassian.JIRA>
References: <JIRA.12916364.1448520894000@Atlassian.JIRA>
 <JIRA.12916364.1448520894053@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9086) ACS allows to create isolated
 networks with invalid gateway IP address
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9086?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15028413#comment-15028413 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9086:
--------------------------------------------

GitHub user kansal opened a pull request:

    https://github.com/apache/cloudstack/pull/1125

    CLOUDSTACK-9086: ACS allows to create isolated networks with invalid =
=E2=80=A6

    =E2=80=A6gateway IP address - Fixed
   =20
    Problem: There was no check for the network and broadcast IP addresses =
in the case where we provide the gateway and netmask while creating the iso=
lated network. As a result the provided IP gets assigned to the eth0 interf=
ace of the VR.
   =20
    Fix: Added the necessary checks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kansal/cloudstack CLOUDSTACK-9086

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1125
   =20
----
commit 27b40e761a398565b1e2a1947c6ba8634c497e40
Author: Kshitij Kansal <kansal.k@gmail.com>
Date:   2015-11-26T06:56:29Z

    CLOUDSTACK-9086: ACS allows to create isolated networks with invalid ga=
teway IP address - Fixed

----


> ACS allows to create isolated networks with invalid gateway IP address
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9086
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-908=
6
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>            Reporter: Kshitij Kansal
>            Assignee: Kshitij Kansal
>
> When entering invalid combination no check is performed anymore and VR is=
 created with invalid interface. Of course, nothing works in the isolated n=
etwork. For example, you are allowed to create network with 172.16.21.0 IP =
address for GW and 255.255.255.0 for SM - this address is not valid, howeve=
r it is accepted and even used in VR. One more example - 192.168.255.255 fo=
r GW address and 255.255.255.0 for SM.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)