Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 27 Nov 2015 19:06:11 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12914990.1448053467000.211243.1448651171058@Atlassian.JIRA>
In-Reply-To: <JIRA.12914990.1448053467000@Atlassian.JIRA>
References: <JIRA.12914990.1448053467000@Atlassian.JIRA>
 <JIRA.12914990.1448053467951@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9077) injectkeys.sh doesn't work on
 CentOS7
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030163#comment-15030163 ] 

ASF subversion and git services commented on CLOUDSTACK-9077:
-------------------------------------------------------------

Commit 92913a154c00cb57a51e90c9622720062eb6a9cb in cloudstack's branch refs/heads/4.6 from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=92913a1 ]

Merge pull request #1109 from remibergsma/fix-CLOUDSTACK-9077

CLOUDSTACK-9077 Fix injectkeys.sh to work on CentOS7Fix regression from commit 3381154fafb7fa4f0a61d538f7c2550e48247787

The error seen on CentOS 7:

```
2015-11-20 21:51:16,161 DEBUG [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) No loop device found, skipping ssh key insertion in systemvm.iso
```

Instead of detecting `/dev/loop0` this checks if we run inside Docker.

Tested on CentOS 7 and that now works again as expected.

```
2015-11-23 16:20:16,777 DEBUG [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) Executing: /bin/bash /var/lib/tomcat/webapps/client/WEB-INF/classes/scripts/vm/systemvm/injectkeys.sh /home/cloud/.ssh/id_rsa.pub /home/cl
oud/.ssh/id_rsa /var/lib/tomcat/webapps/client/WEB-INF/classes/vms/systemvm.iso
2015-11-23 16:20:16,821 DEBUG [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) Execution is successful.
2015-11-23 16:20:16,827 INFO  [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) Injected public and private keys into systemvm iso with result : null
```

Pinging @pdion891 to have a look.

* pr/1109:
  CLOUDSTACK-9077 Fix injectkeys.sh to work on CentOS7

Signed-off-by: Remi Bergsma <github@remi.nl>


> injectkeys.sh doesn't work on CentOS7
> -------------------------------------
>
>                 Key: CLOUDSTACK-9077
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9077
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Remi Bergsma
>            Priority: Critical
>
> Regression from: https://github.com/apache/cloudstack/commit/3381154fafb7fa4f0a61d538f7c2550e48247787
> CentOS7 doesn't have /dev/loop0 so it fails. Removing the check makes it work again.
> ```
> 2015-11-20 21:51:16,145 DEBUG [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) Executing: /bin/bash /var/lib/tomcat/webapps/client/WEB-INF/classes/scripts/vm/systemvm/injectkeys.sh /usr/share/tomc
> at5/.ssh/id_rsa.pub /usr/share/tomcat5/.ssh/id_rsa /var/lib/tomcat/webapps/client/WEB-INF/classes/vms/systemvm.iso
> 2015-11-20 21:51:16,161 DEBUG [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) Execution is successful.
> 2015-11-20 21:51:16,161 DEBUG [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) No loop device found, skipping ssh key insertion in systemvm.iso
> 2015-11-20 21:51:16,162 INFO  [c.c.s.ConfigurationServerImpl] (localhost-startStop-1:null) Injected public and private keys into systemvm iso with result : null
> ```
> Pinging [~pdion]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)