Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 10 Nov 2015 17:56:11 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12911914.1447177139000.29842.1447178171024@Atlassian.JIRA>
In-Reply-To: <JIRA.12911914.1447177139000@Atlassian.JIRA>
References: <JIRA.12911914.1447177139000@Atlassian.JIRA>
 <JIRA.12911914.1447177139553@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9052) Make random generated
 passwords more secure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999005#comment-14999005 ] 

ASF GitHub Bot commented on CLOUDSTACK-9052:
--------------------------------------------

GitHub user nnesic opened a pull request:

    https://github.com/apache/cloudstack/pull/1058

    Shuffling the password to avoid having a subset of characters in fixed positions.

    Related to CLOUDSTACK-9052.
    
    I am shuffling the characters in the password, to avoid having a certain char type in fixed positions. I modified the tests accordingly to only check that the different character types are present. 
    
    I think it would be good to remove the hard requirement to have at least one of digits, upper-case, and  lowercase chars, as it reduces the number of possible combinations passwords can take. What do you think?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr/password_security

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1058
    
----
commit 376a56acf69de1b61a1869e2e223d65ed020062f
Author: nnesic <nera@greenqloud.com>
Date:   2015-11-10T17:22:31Z

    CLOUDSTACK-9052 Shuffling the password to avoid having a subset of characters in fixed positions.

----


> Make random generated passwords more secure
> -------------------------------------------
>
>                 Key: CLOUDSTACK-9052
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9052
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.5.0
>            Reporter: Nera Nesic
>
> Currently, any password generated by the PasswordGenerator that is more than three characters long has a lower-case char, and an upper-case char, and a digit in fixed positions, which reduces the randomness and makes it easier to crack. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)