Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59DB218786 for ; Sat, 28 Nov 2015 13:55:11 +0000 (UTC) Received: (qmail 92140 invoked by uid 500); 28 Nov 2015 13:55:11 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 92110 invoked by uid 500); 28 Nov 2015 13:55:11 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 92101 invoked by uid 500); 28 Nov 2015 13:55:11 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 92098 invoked by uid 99); 28 Nov 2015 13:55:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Nov 2015 13:55:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EE5482C1F58 for ; Sat, 28 Nov 2015 13:55:10 +0000 (UTC) Date: Sat, 28 Nov 2015 13:55:10 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8988) CLOUDSTACK-8988 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8988?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D15030517#comment-15030517 ]=20 ASF GitHub Bot commented on CLOUDSTACK-8988: -------------------------------------------- Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-160297495 =20 @Daanhooglan, I got your point. So, what about if we just fix the reference for that class in =E2=80=9C= async-job-component.xml=E2=80=9D. We could also remove the reference for = =E2=80=9Ccom.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator=E2= =80=9D that does not seem to exist. > CLOUDSTACK-8988 > --------------- > > Key: CLOUDSTACK-8988 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-898= 8 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: Management Server, Projects > Affects Versions: 4.7.0 > Environment: Windows 10; Eclipse; > Reporter: Rodrigo Pedro Marques > Priority: Minor > Labels: easyfix, github-import > Fix For: 4.7.0 > > Original Estimate: 0h > Remaining Estimate: 0h > > Removal of cloud-plugin-storage-allocator-random project that was unused. > File modified: /cloud-server/test/async-job-component.xml. Removed some u= nused adapters.The reason for this is explained as follows. > The adapter configuration is the following: > > class=3D"com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator"= > > 2 > > class=3D"com.cloud.agent.manager.allocator.impl.RandomStoragePoolAllocato= r"> > 2 > > > =E2=80=A2 class=3D"com.cloud.agent.manager.allocator.impl.FirstFitStorage= Allocator" > The class "com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocato= r" does not exist. The only reference for it is found in the following file= : > - /cloud-server/test/async-job-component.xml > Therefore, we can conclude that there is no need for this line at that fi= le. > =E2=80=A2 class=3D"com.cloud.agent.manager.allocator.impl.RandomStoragePo= olAllocator" > Additionally, the class RandomStoragePoolAllocator.java is never used. Th= e only reference is found in the following file: > /cloud-server/test/async-job-component.xml > We found a project called =E2=80=9Ccloud-plugin-storage-allocator-random= =E2=80=9D. This project has only one package that contains only one class, = which is the RandomStoragePoolAllocator.java. Despite the names that are th= e same, the class in =E2=80=9Ccloud-plugin-storage-allocator-random=E2=80= =9D project and the class referenced in - /cloud-server/test/async-job-comp= onent.xml have different packages. Therefore, we removed that configuration= from async-job-component.xml and the project that contains only the Random= StoragePoolAllocator class that is never used. > Consequently, we had to remove the following lines from the /cloud-client= -ui/pom.xml: > > org.apache.cloudstack > cloud-plugin-storage-allocator-random > ${project.version} > > Those changes leave us with an adapter configuration empty with the follo= wing key: > =E2=80=A2 key=3D"com.cloud.agent.manager.allocator.StorageAllocator" > Therefore, we removed it. > Furthermore, after we removed that configuration we noticed that there is= no such class StorageAllocator.java. However, it appears that exists test = for it, like the following classes: > StorageAllocatorTestConfiguration.java > StorageAllocatorTest.java. We are not sure if these classes are tests for= the class StorageAllocator.java and for the possible configuration we have= just removed. If they are, we can remove both classes.=20 > We also removed the following configuration from /cloudstack-plugins/pom.= xml: > storage-allocators/random -- This message was sent by Atlassian JIRA (v6.3.4#6332)