Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Sun, 29 Nov 2015 08:39:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12905492.1444994454000.215773.1448786350946@Atlassian.JIRA>
In-Reply-To: <JIRA.12905492.1444994454000@Atlassian.JIRA>
References: <JIRA.12905492.1444994454000@Atlassian.JIRA>
 <JIRA.12905492.1444994454790@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8958) add dedicated ips to domain
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030844#comment-15030844 ] 

ASF GitHub Bot commented on CLOUDSTACK-8958:
--------------------------------------------

Github user remibergsma commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1007#discussion_r46089078
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final DedicatePublicIpRangeCmd cmd) throws Res
                 vlanOwner = _accountMgr.getAccount(project.getProjectAccountId());
             }
     
    +        Domain domain = null;
             if (accountName != null && domainId != null) {
                 vlanOwner = _accountDao.findActiveAccount(accountName, domainId);
    -        }
    -        if (vlanOwner == null) {
    -            throw new InvalidParameterValueException("Unable to find account by name " + accountName);
    -        } else if (vlanOwner.getId() == Account.ACCOUNT_ID_SYSTEM) {
    -            throw new InvalidParameterValueException("Please specify a valid account. Cannot dedicate IP range to system account");
    +            if (vlanOwner == null) {
    --- End diff --
    
    Looks like the project case is handled by 89ce8bd9e289327f411790eb05a9fb49ef1f9a2f. Since all tests pass, I will merge this now. Future adjustments can be made in a separate PR.


> add dedicated ips to domain
> ---------------------------
>
>                 Key: CLOUDSTACK-8958
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8958
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>
> add dedicated ips to domain 
> ips are dedicated to Account for now, so other customers and projects in the same domain will use the system ip. this is not what we need.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)