Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43EDC18ACE for ; Tue, 10 Nov 2015 08:11:11 +0000 (UTC) Received: (qmail 86735 invoked by uid 500); 10 Nov 2015 08:11:11 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 86699 invoked by uid 500); 10 Nov 2015 08:11:11 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 86683 invoked by uid 500); 10 Nov 2015 08:11:11 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 86669 invoked by uid 99); 10 Nov 2015 08:11:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 08:11:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F2C1A2C1F5A for ; Tue, 10 Nov 2015 08:11:10 +0000 (UTC) Date: Tue, 10 Nov 2015 08:11:10 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8818) Python scripts should depend on mysql.connector instead of MySQLdb MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998227#comment-14998227 ] ASF GitHub Bot commented on CLOUDSTACK-8818: -------------------------------------------- Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-155353598 Pylint result: ``` Global evaluation ----------------- Your code has been rated at 6.48/10 (previous run: 6.48/10, +0.00) ``` I also wrote a small test script: ``` from db import Database db = Database(username='root', password='XXXX') try: db.testConnection() print("Succes!") except: raise ``` The result: ``` wido@wido-laptop:~/repos/cloudstack/python/lib/cloudutils$ python smallthin.py Succes! wido@wido-laptop:~/repos/cloudstack/python/lib/cloudutils$ ``` > Python scripts should depend on mysql.connector instead of MySQLdb > ------------------------------------------------------------------ > > Key: CLOUDSTACK-8818 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8818 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Wido den Hollander > Labels: mysql, python, python3 > > Our current Python scripts depend on MySQLdb for MySQL connections. > The best way to go is the native mysql.connector which implements the MySQL protocol in native Python instead of depending on external libraries. > It would be best if we drop MySQLdb and use mysql.connector since that also supports Python 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)