cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9067) As I developer I want to remove all the unused router-shell scripts from ACS
Date Thu, 19 Nov 2015 17:00:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013875#comment-15013875
] 

ASF subversion and git services commented on CLOUDSTACK-9067:
-------------------------------------------------------------

Commit 791f9dfe5f97c3650a52b16bb7e7c50b553cd25b in cloudstack's branch refs/heads/master from
[~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=791f9df ]

Merge pull request #1084 from ekholabs/improvement/remove_scripts-CLOUDSTACK-9067

CLOUDSTACK-9067 - As I developer I want to remove all the unused router-shell scripts from
ACSThis PR removes the unused shell scripts that were present in the ACS project. Those script
were replaced by the.

Some of the scripts are used by the HyperV Resource, which were hardcoded. I took the opportunity
to use the Java constants over there as well, so the next one touching the code will know
they exist and won't hardcode anything.

The following task were applied:

* Remove the shell files and the Java constants that were mapping them;
* Apply the use of the Java constants to the HyperV Resource class;
* Wrap the String.format() method in the StringUtils so we can test the changes in the HyperV
Resource class.

The last point was added because I do not have a HyperV test environment. Hence, I wanted
to make sure the tiny code I changed is covered at least by unit tests.

* pr/1084:
  CLOUDSTACK-9067 - Replaces hardcoded paths with the VRScripts constants.
  CLOUDSTACK-9067 - Fomatting the code of HypervDirectConnectResource class
  CLOUDSTACK-9067 - Remove old script file from the project

Signed-off-by: Remi Bergsma <github@remi.nl>


> As I developer I want to remove all the unused router-shell scripts from ACS
> ----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9067
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9067
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message