cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9067) As I developer I want to remove all the unused router-shell scripts from ACS
Date Wed, 18 Nov 2015 12:18:10 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010880#comment-15010880
] 

ASF GitHub Bot commented on CLOUDSTACK-9067:
--------------------------------------------

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1084#issuecomment-157693480
  
    @miguelaferreira discussed with me the over-engineering wrapper method just to add 1 test
and we agreed on getting rid of it for the following reasons:
    
    1. It could lead other committers to add simple tests - like the one I added - and forget
about the real tests that we need;
    2. An experienced Software Engineer reviewing the code will spot problems with the string
formats used.
    
    I will retest the PR and post the results here.
    
    Cheers,
    Wilder 


> As I developer I want to remove all the unused router-shell scripts from ACS
> ----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9067
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9067
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message