cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9065) Packaging RPM: Add option for package release version, cleanup and lint
Date Wed, 18 Nov 2015 07:59:10 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010427#comment-15010427
] 

ASF GitHub Bot commented on CLOUDSTACK-9065:
--------------------------------------------

Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1075#discussion_r45169717
  
    --- Diff: packaging/package.sh ---
    @@ -18,26 +18,37 @@
     
     function usage() {
         echo ""
    -    echo "usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]"
    +    echo "usage: ./package.sh [-h|--help] -d|--distribution <name> [-r|--release
<version>] [-p|--pack oss|OSS|noredist|NOREDIST] [-s|--simulator default|DEFAULT|simulator|SIMULATOR]"
         echo ""
    -    echo "The commonly used Arguments are:"
    -    echo "-p|--pack oss|OSS             To package with only redistributable libraries
(default)"
    -    echo "-p|--pack noredist|NOREDIST   To package with non-redistributable libraries"
    -    echo "-d centos7|centos63|fedora20|fedora21  To build a package for a distribution"
    -    echo "-s simulator|SIMULATOR        To build for Simulator"
    +    echo "The supported arguments are:"
    +    echo "  To package with only redistributable libraries (default)"
    +    echo "    -p|--pack oss|OSS"
    +    echo "  To package with non-redistributable libraries"
    +    echo "    -p|--pack noredist|NOREDIST"
    +    echo "  To build a package for a distribution (mandatory)"
    +    echo "    -d|--distribution centos7|centos63|fedora20|fedora21"
    +    echo "  To set the package release version (optional)"
    +    echo "  (default is 1 for normal and prereleases, empty for SNAPSHOT)"
    +    echo "    -r|--release version(integer)"
    +    echo "  To build for Simulator (optional)"
    +    echo "    -s|--simulator default|DEFAULT|simulator|SIMULATOR"
    +    echo "  To display this information"
    +    echo "    -h|--help"
         echo ""
    -    echo "Examples: ./package.sh -p|--pack oss|OSS"
    -    echo "          ./package.sh -p|--pack noredist|NOREDIST"
    -    echo "          ./package.sh (Default OSS)"
    -    exit 1
    +    echo "Examples: ./package.sh --pack oss"
    +    echo "          ./package.sh --pack noredist"
    +    echo "          ./package.sh --pack oss --distribution centos7 --release 42"
    --- End diff --
    
    @davidamorimfaria, what are the implications in giving a release number? For example,
giving 4.6 or nothing will reflect in a different package or is it just for the final RPM
file name?
    
    For the looks on the code, it seems to be only the file name. :)
    
    No big deal, I'm just curious. I will take some time to test your PR today.


> Packaging RPM: Add option for package release version, cleanup and lint
> -----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9065
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9065
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Packaging
>    Affects Versions: 4.6.0
>            Reporter: David Amorim Faria
>            Assignee: David Amorim Faria
>            Priority: Trivial
>
> In RPM Packaging, add option for package release version.
> Also, code cleanup and some linting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message