cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9063) CitrixResourceBase refactor
Date Tue, 17 Nov 2015 14:55:10 GMT


ASF GitHub Bot commented on CLOUDSTACK-9063:

Github user wilderrodrigues commented on the pull request:
    Hi @DaanHoogland,
    I run integration tests before creating the PRs and that's not manually and I do have
only 1 bubble. I just do:
    * build code/RPMs
    * run MS
    * deploy DC
    * run tests
    I could do that before the bubble as well... remember my endless iptables list? ;)
    I only feel comfortable with creating a PR if I know the system is still working. I have
been fixing problems before due to PRs that were not tested and broke master. With me it only
happened 2 times, but it took me 4 weeks to find out which commit - not mine - broke it. I
am just trying to avoid that again.
    Concerning the inline get calls, you don't have to change it. It would improve readability,
but that's not a blocker. However, the PR needs to be tested against XenServer at least by
1 reviewer - or a CI that tests something (not against a simulator). 

> CitrixResourceBase refactor
> ---------------------------
>                 Key: CLOUDSTACK-9063
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
> report
on the class is pretty bad. Some trivial changes can be done to improve. miracles won't happen
but improvements can be made.

This message was sent by Atlassian JIRA

View raw message