cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9063) CitrixResourceBase refactor
Date Tue, 17 Nov 2015 06:38:10 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008146#comment-15008146
] 

ASF GitHub Bot commented on CLOUDSTACK-9063:
--------------------------------------------

Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1066#discussion_r45026523
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java
---
    @@ -55,10 +55,10 @@ public void umountSnapshotDir(final Connection conn, final Long dcId)
{}
     
         @Override
         public boolean setupServer(final Connection conn,final Host host) {
    -        final com.trilead.ssh2.Connection sshConnection = new com.trilead.ssh2.Connection(_host.getIp(),
22);
    +        final com.trilead.ssh2.Connection sshConnection = new com.trilead.ssh2.Connection(getXenServerHost().getIp(),
22);
             try {
                 sshConnection.connect(null, 60000, 60000);
    -            if (!sshConnection.authenticateWithPassword(_username, _password.peek()))
{
    +            if (!sshConnection.authenticateWithPassword(getData().getUsername(), getData().getPasswords().peek()))
{
    --- End diff --
    
    It's not senseless... it improves readability.


> CitrixResourceBase refactor
> ---------------------------
>
>                 Key: CLOUDSTACK-9063
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9063
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>
> https://analysis.apache.org/drilldown/measures/100206?metric=class_complexity report
on the class is pretty bad. Some trivial changes can be done to improve. miracles won't happen
but improvements can be made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message