cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9063) CitrixResourceBase refactor
Date Mon, 16 Nov 2015 10:06:11 GMT


ASF GitHub Bot commented on CLOUDSTACK-9063:

Github user DaanHoogland commented on the pull request:
    I will look at the changes to see if extra unit tests are needed. I have not introduced
any logical changes so far.
    I aggree that we should not merge anything called [WIP]... it shall have to be renamed
before merging. It does not contradict the way we have worked lately.
    Making it a PR gives the advantage of the automated tests.

> CitrixResourceBase refactor
> ---------------------------
>                 Key: CLOUDSTACK-9063
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
> report
on the class is pretty bad. Some trivial changes can be done to improve. miracles won't happen
but improvements can be made.

This message was sent by Atlassian JIRA

View raw message