cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9063) CitrixResourceBase refactor
Date Mon, 16 Nov 2015 08:34:10 GMT


ASF GitHub Bot commented on CLOUDSTACK-9063:

Github user wilderrodrigues commented on the pull request:
    Hi @DaanHoogland 
    Since this is still WIP, would be nice to extract local variable instead of calling all
those methods in line. Also, I haven't seen any change in the existing unit tests.

> CitrixResourceBase refactor
> ---------------------------
>                 Key: CLOUDSTACK-9063
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
> report
on the class is pretty bad. Some trivial changes can be done to improve. miracles won't happen
but improvements can be made.

This message was sent by Atlassian JIRA

View raw message