cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9063) CitrixResourceBase refactor
Date Mon, 16 Nov 2015 08:34:10 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006338#comment-15006338
] 

ASF GitHub Bot commented on CLOUDSTACK-9063:
--------------------------------------------

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1066#issuecomment-156955059
  
    Hi @DaanHoogland 
    
    Since this is still WIP, would be nice to extract local variable instead of calling all
those methods in line. Also, I haven't seen any change in the existing unit tests.
    
    Cheers,
    Wilder


> CitrixResourceBase refactor
> ---------------------------
>
>                 Key: CLOUDSTACK-9063
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9063
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>
> https://analysis.apache.org/drilldown/measures/100206?metric=class_complexity report
on the class is pretty bad. Some trivial changes can be done to improve. miracles won't happen
but improvements can be made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message