cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9063) CitrixResourceBase refactor
Date Fri, 20 Nov 2015 09:44:11 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015510#comment-15015510
] 

ASF GitHub Bot commented on CLOUDSTACK-9063:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1066#discussion_r45450911
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceData.java
---
    @@ -0,0 +1,289 @@
    +package com.cloud.hypervisor.xenserver.resource;
    +
    +import java.util.LinkedList;
    +import java.util.Queue;
    +
    +public class CitrixResourceData {
    --- End diff --
    
    What is the need/justification for creating this data class? The data members were already
part of appropriate XS resource classes. I don't see any benefit here from another level of
indirection.


> CitrixResourceBase refactor
> ---------------------------
>
>                 Key: CLOUDSTACK-9063
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9063
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>
> https://analysis.apache.org/drilldown/measures/100206?metric=class_complexity report
on the class is pretty bad. Some trivial changes can be done to improve. miracles won't happen
but improvements can be made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message