cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9047) rename enums to match best practice naming pattern
Date Tue, 10 Nov 2015 07:45:11 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998115#comment-14998115
] 

ASF GitHub Bot commented on CLOUDSTACK-9047:
--------------------------------------------

Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1049#issuecomment-155347860
  
    Since all tests are still passing and based on the code a LGTM from me.


> rename enums to match best practice naming pattern
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-9047
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9047
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>
> Enums should have a name starting with a capital according to java best practices. Rename
those that don't and add unit tests where relevant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message