cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9047) rename enums to match best practice naming pattern
Date Wed, 18 Nov 2015 10:35:11 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010717#comment-15010717
] 

ASF GitHub Bot commented on CLOUDSTACK-9047:
--------------------------------------------

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1049#issuecomment-157673706
  
    @wilderrodrigues @wido can you review. The test keeps giving an exception but the destroyed
suystem vms come back without problems and the test suite can even be run again on the same
environment. I think this PR is alright.


> rename enums to match best practice naming pattern
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-9047
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9047
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>
> Enums should have a name starting with a capital according to java best practices. Rename
those that don't and add unit tests where relevant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message