cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-6276) Affinity Groups within projects
Date Sun, 29 Nov 2015 13:49:11 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030944#comment-15030944
] 

ASF GitHub Bot commented on CLOUDSTACK-6276:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1134#discussion_r46092314
  
    --- Diff: api/src/org/apache/cloudstack/affinity/AffinityGroupService.java ---
    @@ -18,47 +18,36 @@
     
     import java.util.List;
     
    +import org.apache.cloudstack.api.command.user.affinitygroup.CreateAffinityGroupCmd;
    +
     import com.cloud.uservm.UserVm;
    -import com.cloud.utils.Pair;
     
     public interface AffinityGroupService {
     
         /**
          * Creates an affinity/anti-affinity group for the given account/domain.
          *
    -     * @param account
    +     * @param accountName
    +     * @param projectId
          * @param domainId
    -     * @param name
    -     * @param type
    +     * @param affinityGroupName
    +     * @param affinityGroupType
          * @param description
          * @return AffinityGroup
          */
    +    AffinityGroup createAffinityGroup(String accountName, Long projectId, Long domainId,
String affinityGroupName, String affinityGroupType, String description);
     
    -    AffinityGroup createAffinityGroup(String account, Long domainId, String affinityGroupName,
String affinityGroupType, String description);
    +    AffinityGroup createAffinityGroup(CreateAffinityGroupCmd createAffinityGroupCmd);
     
         /**
          * Creates an affinity/anti-affinity group.
          *
          * @param affinityGroupId
    -     * @param account
    -     * @param domainId
    -     * @param affinityGroupName
    -     */
    -    boolean deleteAffinityGroup(Long affinityGroupId, String account, Long domainId,
String affinityGroupName);
    -
    -    /** Lists Affinity Groups in your account
    -     * @param account
    +     * @param accountName
          * @param domainId
    -     * @param affinityGroupId
          * @param affinityGroupName
    -     * @param affinityGroupType
    -     * @param vmId
    -     * @param startIndex
    -     * @param pageSize
    -     * @return
          */
    -    Pair<List<? extends AffinityGroup>, Integer> listAffinityGroups(Long
affinityGroupId, String affinityGroupName, String affinityGroupType, Long vmId, Long startIndex,
    --- End diff --
    
    @pdube does it not make sense to list affinity groups?


> Affinity Groups within projects
> -------------------------------
>
>                 Key: CLOUDSTACK-6276
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6276
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>            Reporter: Ingo Jochim
>
> Hello,
> I like to have the features "Affinity Group" and "Project" combined.
> As far as I know I cannot use Affinity Groups within Projects.
> Thanks and regards,
> Ingo



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message