Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 22 Oct 2015 10:51:27 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12906491.1445423443000.27893.1445511087688@Atlassian.JIRA>
In-Reply-To: <JIRA.12906491.1445423443000@Atlassian.JIRA>
References: <JIRA.12906491.1445423443000@Atlassian.JIRA>
 <JIRA.12906491.1445423443582@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8975) [Automation]skip test case if
 niciraNvp settings are not available in config file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D14968950#comment-14968950 ]=20

ASF GitHub Bot commented on CLOUDSTACK-8975:
--------------------------------------------

Github user runseb commented on the pull request:

    https://github.com/apache/cloudstack/pull/960#issuecomment-150178317
 =20
    I think you guys agree on the problem but disagree on the solution.
    To me 100% success on BVT, if it includes ~20% (or whatever percentage)=
 of skipped tests is not a real 100% success rate on BVT.
   =20
    So @miguelaferreira prefers to see 80% success on BVT and vote +1 on a =
release, if he actually knows what's happening with the 20% failure.
    While @nitt10prashant and @pvr9711 you seem to want 100% success on BVT=
 even if it includes some tests that are actually not run.
   =20
    The nicira test is actually the only one in there that's testing a thir=
d party plugin. I don't see any tests for solidfire, netscaler, open contra=
il, midokura etc=E2=80=A6.All theses tests will fail without the proper har=
dware/software setup and hence will fail with simulator run.
   =20
    If we really want 100% on integration tests (so called BVT) we need to =
define a test suite that everyone can run without special hardware or softw=
are. And those tests *cannot* be skipped.
   =20
    I personally fail to see the benefit of skipped tests versus a failed t=
est.
   =20
    For this particular tests I propose we move it to a folder /test/integr=
ation/plugins and have our base tests defining "BVT" as the test in /test/i=
ntegration/smoke
   =20
    So -1 on this PR
    +1 on a PR that would move this test to a separate folder.
   =20


> [Automation]skip test case if niciraNvp settings are not available in con=
fig file
> -------------------------------------------------------------------------=
--------
>
>                 Key: CLOUDSTACK-8975
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-897=
5
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: Automation
>    Affects Versions: 4.7.0
>            Reporter: prashant kumar mishra
>            Assignee: prashant kumar mishra
>            Priority: Minor
>             Fix For: 4.7.0
>
>
> /root/cloudstack/test/integration/smoke/test_nicira_controller.py   is fa=
iling if niciraNvp settings are not available in config file. Modifying scr=
ipt to skip test case if settings are not available=20
> log
> =3D=3D=3D=3D=3D=3D=3D
> File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py",=
 line 46, in setUpClass
>     cls.nicira_hosts      =3D cls.config.niciraNvp.hosts
> AttributeError: 'NoneType' object has no attribute 'hosts'
> -------------------- >> begin captured stdout << ---------------------
> =3D=3D=3D TestName: None | Status : EXCEPTION =3D=3D=3D


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)