Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1B66D18766 for ; Thu, 22 Oct 2015 10:17:28 +0000 (UTC) Received: (qmail 73946 invoked by uid 500); 22 Oct 2015 10:17:28 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 73904 invoked by uid 500); 22 Oct 2015 10:17:27 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 73894 invoked by uid 500); 22 Oct 2015 10:17:27 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 73890 invoked by uid 99); 22 Oct 2015 10:17:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 10:17:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BFEBF2C14F3 for ; Thu, 22 Oct 2015 10:17:27 +0000 (UTC) Date: Thu, 22 Oct 2015 10:17:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8975) [Automation]skip test case if niciraNvp settings are not available in config file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968906#comment-14968906 ] ASF GitHub Bot commented on CLOUDSTACK-8975: -------------------------------------------- Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-150169879 Does 100% pass rate when some of the tests have been skipped mean more than 100% pass rate when the same tests have been excluded? I only hear about these BTV tests when a release is being prepared (I could be wrong, and you maybe run these tests all the time). I'm actually building a CI setup that will run every day all day, for all PRs. In such a setup I would have made my live easier by just taking all the test available. But instead I choose to careful select the test I'm running, to be sure about what I'm testing. I already see that several tests need to be improved, and then more tests added, and so on. This will lead to sustainable improvement. Now, if you say that it is hard to maintain a list of tests to include in a build, I would say that is the problem of the build and not the tests. > [Automation]skip test case if niciraNvp settings are not available in config file > --------------------------------------------------------------------------------- > > Key: CLOUDSTACK-8975 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Automation > Affects Versions: 4.7.0 > Reporter: prashant kumar mishra > Assignee: prashant kumar mishra > Priority: Minor > Fix For: 4.7.0 > > > /root/cloudstack/test/integration/smoke/test_nicira_controller.py is failing if niciraNvp settings are not available in config file. Modifying script to skip test case if settings are not available > log > ======= > File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py", line 46, in setUpClass > cls.nicira_hosts = cls.config.niciraNvp.hosts > AttributeError: 'NoneType' object has no attribute 'hosts' > -------------------- >> begin captured stdout << --------------------- > === TestName: None | Status : EXCEPTION === -- This message was sent by Atlassian JIRA (v6.3.4#6332)