Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16DF017A8E for ; Tue, 20 Oct 2015 22:15:38 +0000 (UTC) Received: (qmail 15663 invoked by uid 500); 20 Oct 2015 22:15:28 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 15460 invoked by uid 500); 20 Oct 2015 22:15:28 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 15406 invoked by uid 500); 20 Oct 2015 22:15:28 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 15392 invoked by uid 99); 20 Oct 2015 22:15:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 22:15:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DA4C22C1F76 for ; Tue, 20 Oct 2015 22:15:27 +0000 (UTC) Date: Tue, 20 Oct 2015 22:15:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8971) Remove hardcoded configuration from test_privategw_acl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965867#comment-14965867 ] ASF GitHub Bot commented on CLOUDSTACK-8971: -------------------------------------------- Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/957#issuecomment-149718198 It works fine for me: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false smoke/test_privategw_acl.py ``` Result: ``` test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 1 test in 223.325s OK ``` Based on the above: LGTM @michaelandersen are you sure it isn't a local problem? Maybe try to deploy again? I'll hold this PR until tomorrow morning. > Remove hardcoded configuration from test_privategw_acl > ------------------------------------------------------ > > Key: CLOUDSTACK-8971 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8971 > Project: CloudStack > Issue Type: Test > Security Level: Public(Anyone can view this level - this is the default.) > Components: Test > Reporter: Wilder Rodrigues > Assignee: Wilder Rodrigues > > The current test_privategw_acl.py has come hardcoded configuration that makes it not very reliable: > * self.networkOfferingId = 11 > * self.zoneId = 1 > * self.serviceOfferingId = 1 > * self.templateId = 5 > The current test does not clean up the resources created. This has to be added as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)