Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 99B571816B for ; Tue, 27 Oct 2015 08:24:28 +0000 (UTC) Received: (qmail 64291 invoked by uid 500); 27 Oct 2015 08:24:28 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 63975 invoked by uid 500); 27 Oct 2015 08:24:28 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 63796 invoked by uid 500); 27 Oct 2015 08:24:28 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 63786 invoked by uid 99); 27 Oct 2015 08:24:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 08:24:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 09BCB2C1F5C for ; Tue, 27 Oct 2015 08:24:28 +0000 (UTC) Date: Tue, 27 Oct 2015 08:24:28 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975972#comment-14975972 ] ASF GitHub Bot commented on CLOUDSTACK-8832: -------------------------------------------- Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43093355 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java --- @@ -17,38 +17,42 @@ // under the License. // -package com.cloud.agent.api.guru; +package com.cloud.agent.api.manager; import com.cloud.agent.api.Command; -public class ReleaseVmVspCommand extends Command { +public class SupportedApiVersionCommand extends Command { - String _networkUuid; - String _vmUuid; - String _vmInstanceName; + private final String _apiVersion; - public ReleaseVmVspCommand(String networkUuid, String vmUuid, String vmInstanceName) { + public SupportedApiVersionCommand(String apiVersion) { super(); - this._networkUuid = networkUuid; - this._vmUuid = vmUuid; - this._vmInstanceName = vmInstanceName; + this._apiVersion = apiVersion; } - public String getNetworkUuid() { - return _networkUuid; + public String getApiVersion() { + return _apiVersion; } - public String getVmUuid() { - return _vmUuid; + @Override + public boolean executeInSequence() { + return false; } - public String getVmInstanceName() { - return _vmInstanceName; + @Override + public boolean equals(Object o) { --- End diff -- Implemented equals method for the Command super class, calling it from subclass. > Update Nuage VSP plugin to work with Nuage VSP release 3.2 > ---------------------------------------------------------- > > Key: CLOUDSTACK-8832 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Affects Versions: 4.6.0 > Reporter: Nick Livens > Assignee: Nick Livens > Attachments: nuageVspMarvinLogs.tar.gz > > > Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release -- This message was sent by Atlassian JIRA (v6.3.4#6332)