Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 80B65189A6 for ; Mon, 26 Oct 2015 17:37:28 +0000 (UTC) Received: (qmail 50799 invoked by uid 500); 26 Oct 2015 17:37:28 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 50597 invoked by uid 500); 26 Oct 2015 17:37:28 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 50213 invoked by uid 500); 26 Oct 2015 17:37:27 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 50208 invoked by uid 99); 26 Oct 2015 17:37:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Oct 2015 17:37:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C54952C1F62 for ; Mon, 26 Oct 2015 17:37:27 +0000 (UTC) Date: Mon, 26 Oct 2015 17:37:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974613#comment-14974613 ] ASF GitHub Bot commented on CLOUDSTACK-8832: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43026042 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java --- @@ -17,18 +17,37 @@ // under the License. // -package com.cloud.agent.api.element; +package com.cloud.agent.api; -import com.cloud.agent.api.Answer; +import com.cloud.host.Host; -public class ShutDownVpcVspAnswer extends Answer { +public class PingNuageVspCommand extends PingCommand { - public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, boolean success, String details) { - super(cmd, success, details); + private final boolean shouldAudit; + + public PingNuageVspCommand(Host.Type type, long id, boolean shouldAudit) { + super(type, id); + this.shouldAudit = shouldAudit; } - public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, Exception e) { - super(cmd, e); + public boolean shouldAudit() { + return shouldAudit; } + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + + PingNuageVspCommand that = (PingNuageVspCommand) o; + + if (shouldAudit != that.shouldAudit) return false; + + return true; + } + + @Override + public int hashCode() { --- End diff -- This ``hashCode`` implementation should include attributes from the ``PingCommand`` super class. > Update Nuage VSP plugin to work with Nuage VSP release 3.2 > ---------------------------------------------------------- > > Key: CLOUDSTACK-8832 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Affects Versions: 4.6.0 > Reporter: Nick Livens > Assignee: Nick Livens > Attachments: nuageVspMarvinLogs.tar.gz > > > Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release -- This message was sent by Atlassian JIRA (v6.3.4#6332)