Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 23 Oct 2015 18:02:27 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12852238.1438781369000.42990.1445623347772@Atlassian.JIRA>
In-Reply-To: <JIRA.12852238.1438781369000@Atlassian.JIRA>
References: <JIRA.12852238.1438781369000@Atlassian.JIRA>
 <JIRA.12852238.1438781369952@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8708) Use Google Gson 2.3.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8708?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D14971478#comment-14971478 ]=20

ASF GitHub Bot commented on CLOUDSTACK-8708:
--------------------------------------------

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/932#issuecomment-150648494
 =20
    @DaanHoogland I have the same result as @borisroman reports:
   =20
    ```
    =3D=3D=3D=3D Deploy DC Started =3D=3D=3D=3D
    Exception Occurred: ['Traceback (most recent call last):\n', '  File "/=
data/git/cs1/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 254,=
 in createPrimaryStorages\n    ret =3D self.__apiClient.createStoragePool(p=
rimarycmd)\n', '  File "/usr/lib/python2.7/site-packages/marvin/cloudstackA=
PI/cloudstackAPIClient.py", line 1727, in createStoragePool\n    response =
=3D self.connection.marvinRequest(command, response_type=3Dresponse, method=
=3Dmethod)\n', '  File "/usr/lib/python2.7/site-packages/marvin/cloudstackC=
onnection.py", line 379, in marvinRequest\n    raise e\n', 'CloudstackAPIEx=
ception: Execute cmd: createstoragepool failed, due to: errorCode: 530, err=
orText:Failed to add data store: Failed to access storage pool\n']
    ```


> Use Google Gson 2.3.1
> ---------------------
>
>                 Key: CLOUDSTACK-8708
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-870=
8
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>    Affects Versions: 4.6.0
>            Reporter: Wido den Hollander
>            Assignee: Daan Hoogland
>            Priority: Critical
>              Labels: gson, reflection
>
> Currently CloudStack uses Google GSON 1.7.2 which is from 30-Sep-2011.
> This is a outdated version. CLOUDSTACK-8677 (Call-Home feature) uses GSON=
 2.3.1 (20-Nov-2014) which is not compatible with the current code.
> The roadmap of Gson shows that since 2.0 there is a change in casting: ht=
tps://sites.google.com/site/gson/gson-roadmap
> "Gson 2.0 doesn=E2=80=99t support type adapters for primitive types."
> The "com.cloud.agent.transport.RequestTest" test in "core" fails with the=
 new Gson version and this leads back to "ArrayTypeAdaptor" which does the =
serializing and de-serializing of JSON to Objects and back.
> Class<?> type =3D ((Class<?>)typeOfT).getComponentType();
> Fails, since getComponentType() doesn't return com.cloud.api.Command.
> This seems to be a Java Reflection issue.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)