Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1434183C7 for ; Wed, 14 Oct 2015 14:15:05 +0000 (UTC) Received: (qmail 36610 invoked by uid 500); 14 Oct 2015 14:15:05 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 36582 invoked by uid 500); 14 Oct 2015 14:15:05 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 36573 invoked by uid 500); 14 Oct 2015 14:15:05 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 36570 invoked by uid 99); 14 Oct 2015 14:15:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Oct 2015 14:15:05 +0000 Date: Wed, 14 Oct 2015 14:15:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8708) Use Google Gson 2.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8708?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D14957006#comment-14957006 ]=20 ASF GitHub Bot commented on CLOUDSTACK-8708: -------------------------------------------- Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/932#discussion_r41998154 =20 --- Diff: pom.xml --- @@ -73,7 +73,7 @@ 1.9.2 1.0.0-build217 2.6.9 - 1.7.2 + [2.4,) --- End diff -- =20 Our standard currently is to pin to a specific version, in this case yo= u depend on any 2.4.X version. Although I understand your reasons, is this = the PR to change that behavior? =20 It makes testing harder when deps change as long as we don't have prope= r testing in place. > Use Google Gson 2.3.1 > --------------------- > > Key: CLOUDSTACK-8708 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-870= 8 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Affects Versions: 4.6.0 > Reporter: Wido den Hollander > Assignee: Daan Hoogland > Priority: Critical > Labels: gson, reflection > > Currently CloudStack uses Google GSON 1.7.2 which is from 30-Sep-2011. > This is a outdated version. CLOUDSTACK-8677 (Call-Home feature) uses GSON= 2.3.1 (20-Nov-2014) which is not compatible with the current code. > The roadmap of Gson shows that since 2.0 there is a change in casting: ht= tps://sites.google.com/site/gson/gson-roadmap > "Gson 2.0 doesn=E2=80=99t support type adapters for primitive types." > The "com.cloud.agent.transport.RequestTest" test in "core" fails with the= new Gson version and this leads back to "ArrayTypeAdaptor" which does the = serializing and de-serializing of JSON to Objects and back. > Class type =3D ((Class)typeOfT).getComponentType(); > Fails, since getComponentType() doesn't return com.cloud.api.Command. > This seems to be a Java Reflection issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)