cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9004) Add functionality to LibvirtVMDef.HyperVEnlightenmentFeatureDef
Date Fri, 30 Oct 2015 22:38:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983508#comment-14983508
] 

ASF GitHub Bot commented on CLOUDSTACK-9004:
--------------------------------------------

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1013#issuecomment-152667236
  
    I can see that your code does what you say in the description @jharsman but I totally
lack the background in windows to judge whether this make sense. Can you expand on the reason
behind this change here or in the jira ticket? Code looks good, change I cannot judge.
    
    Also I can see you created this as a subtask but not to what. Can you give that context?
    
    If you are already discussing this with someone else in the community please ping them
here so they can comment and compensate for my ignorance.
    
    Thanks for working on Apache CloudStack!


> Add functionality to LibvirtVMDef.HyperVEnlightenmentFeatureDef
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9004
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9004
>             Project: CloudStack
>          Issue Type: Sub-task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.5.2
>            Reporter: Josh Harshman
>            Priority: Minor
>              Labels: easyfix, patch, perfomance, windows
>
> LibvirtVMDef.HyperVEnlightenmentFeatureDef only supports the setting of the relaxed mode
feature.  This change will expand the subclass to be able to set vapic and spinlock boolean
values, as well as spinlock retry value.
> These values will then be written out to the XML appropriately. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message