cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8981) test fails when port is reachable
Date Fri, 23 Oct 2015 17:52:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971457#comment-14971457
] 

ASF GitHub Bot commented on CLOUDSTACK-8981:
--------------------------------------------

Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/965#issuecomment-150646084
  
    Compilation and testing went successfull. As it only involved a change of a unit test,
I hadn't ran integration tests.
    
    ```
    Running com.cloud.utils.rest.BasicRestClientTest
    2015-10-23 18:51:01,522 DEBUG [utils.rest.BasicRestClient] (main:) Executig GET request
on https://fakelocalhost.fakelocaldomain:443/path
    2015-10-23 18:51:01,525 DEBUG [utils.rest.BasicRestClient] (main:) Executig GET request
on https://fakelocalhost.fakelocaldomain:443/path
    2015-10-23 18:51:01,584 DEBUG [utils.rest.BasicRestClient] (main:) Executig GET request
on https://fakelocalhost.fakelocaldomain:443/path
    Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.083 sec - in com.cloud.utils.rest.BasicRestClientTest
    ```
    
    Ping @DaanHoogland @remibergsma 
    
    LGTM :+1: 


> test fails when port is reachable
> ---------------------------------
>
>                 Key: CLOUDSTACK-8981
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8981
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>
> BasicRestClientTest.testExecuteRequestWhenClientThrowsIOException fails when the address
that is tested against can be reached because of a developers machine configuration. A clear
message is needed when the exception is not thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message