cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8971) Remove hardcoded configuration from test_privategw_acl
Date Tue, 20 Oct 2015 22:15:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965867#comment-14965867
] 

ASF GitHub Bot commented on CLOUDSTACK-8971:
--------------------------------------------

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/957#issuecomment-149718198
  
    It works fine for me:
    
    ```
    nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false
smoke/test_privategw_acl.py
    ```
    
    Result:
    ```
    test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_privategw_acl | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 223.325s
    
    OK
    ```
    
    Based on the above: LGTM
    
    @michaelandersen are you sure it isn't a local problem? Maybe try to deploy again? I'll
hold this PR until tomorrow morning.


> Remove hardcoded configuration from test_privategw_acl
> ------------------------------------------------------
>
>                 Key: CLOUDSTACK-8971
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8971
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Test
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>
> The current test_privategw_acl.py has come hardcoded configuration that makes it not
very reliable:
> * self.networkOfferingId = 11
> * self.zoneId = 1
> * self.serviceOfferingId = 1
> * self.templateId = 5
> The current test does not clean up the resources created. This has to be added as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message