cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Tue, 27 Oct 2015 08:29:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975998#comment-14975998
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43093698
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -194,7 +224,23 @@ public boolean configure(String name, Map<String, Object> params)
throws Configu
         @Override
         public boolean implement(Network network, NetworkOffering offering, DeployDestination
dest, ReservationContext context) throws ConcurrentOperationException,
                 ResourceUnavailableException, InsufficientCapacityException {
    -        s_logger.debug("Entering NuageElement implement function for network " + network.getDisplayText()
+ " (state " + network.getState() + ")");
    +        if (s_logger.isDebugEnabled()) {
    +            s_logger.debug("Entering NuageElement implement function for network " +
network.getDisplayText() + " (state " + network.getState() + ")");
    +        }
    +
    +        if (network.getVpcId() != null) {
    +            List<NetworkACLItemVO> rules;
    +            if (network.getNetworkACLId() != null) {
    +                rules = _networkACLItemDao.listByACL(network.getNetworkACLId());
    +            } else {
    +                rules = Collections.emptyList();
    +            }
    --- End diff --
    
    Changed parameter of <code>NetworKACLItemDAO.listByACL(long)</code> to <code>Long</code>,
and returning an empty list in case of <code>null</code>.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message