cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Tue, 27 Oct 2015 08:22:28 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975969#comment-14975969
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43093227
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
    @@ -48,13 +53,93 @@ public boolean isL3Network() {
             return _isL3Network;
         }
     
    +    public boolean isSharedNetwork() {
    +        return _isSharedNetwork;
    +    }
    +
         public String getVpcUuid() {
             return _vpcUuid;
         }
     
    +    public String getDomainTemplateName() {
    +        return _domainTemplateName;
    +    }
    +
    +    public static class Builder implements CmdBuilder<TrashNetworkVspCommand> {
    +        private String _domainUuid;
    +        private String _networkUuid;
    +        private boolean _isL3Network;
    +        private boolean _isSharedNetwork;
    +        private String _vpcUuid;
    +        private String _domainTemplateName;
    +
    +        public Builder domainUuid(String domainUuid) {
    +            this._domainUuid = domainUuid;
    +            return this;
    +        }
    +
    +        public Builder networkUuid(String networkUuid) {
    +            this._networkUuid = networkUuid;
    +            return this;
    +        }
    +
    +        public Builder isL3Network(boolean isL3Network) {
    +            this._isL3Network = isL3Network;
    +            return this;
    +        }
    +
    +        public Builder isSharedNetwork(boolean isSharedNetwork) {
    +            this._isSharedNetwork = isSharedNetwork;
    +            return this;
    +        }
    +
    +        public Builder vpcUuid(String vpcUuid) {
    +            this._vpcUuid = vpcUuid;
    +            return this;
    +        }
    +
    +        public Builder domainTemplateName(String domainTemplateName) {
    +            this._domainTemplateName = domainTemplateName;
    +            return this;
    +        }
    +
    +        @Override
    +        public TrashNetworkVspCommand build() {
    +            return new TrashNetworkVspCommand(_domainUuid, _networkUuid, _isL3Network,
_isSharedNetwork, _vpcUuid, _domainTemplateName);
    +        }
    +    }
    +
         @Override
         public boolean executeInSequence() {
             return false;
         }
     
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (o == null || getClass() != o.getClass()) return false;
    +
    +        TrashNetworkVspCommand that = (TrashNetworkVspCommand) o;
    +
    +        if (_isL3Network != that._isL3Network) return false;
    +        if (_isSharedNetwork != that._isSharedNetwork) return false;
    +        if (_domainTemplateName != null ? !_domainTemplateName.equals(that._domainTemplateName)
: that._domainTemplateName != null)
    +            return false;
    +        if (_domainUuid != null ? !_domainUuid.equals(that._domainUuid) : that._domainUuid
!= null) return false;
    +        if (_networkUuid != null ? !_networkUuid.equals(that._networkUuid) : that._networkUuid
!= null) return false;
    +        if (_vpcUuid != null ? !_vpcUuid.equals(that._vpcUuid) : that._vpcUuid != null)
return false;
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    --- End diff --
    
    Implemented <code>hashCode</code> method for the <code>Command</code>
super class, calling it from subclass.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message