cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Tue, 27 Oct 2015 08:21:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975960#comment-14975960
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43093132
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
    @@ -83,9 +92,130 @@ public String getVmUuid() {
             return _vmUuid;
         }
     
    +    public boolean isExpungingState() {
    +        return _isExpungingState;
    +    }
    +
    +    public static class Builder implements CmdBuilder<DeallocateVmVspCommand> {
    +        private String _networkUuid;
    +        private String _nicFromDdUuid;
    +        private String _nicMacAddress;
    +        private String _nicIp4Address;
    +        private boolean _isL3Network;
    +        private boolean _isSharedNetwork;
    +        private String _vpcUuid;
    +        private String _networksDomainUuid;
    +        private String _vmInstanceName;
    +        private String _vmUuid;
    +        private boolean _isExpungingState;
    +
    +        public Builder networkUuid(String networkUuid) {
    +            this._networkUuid = networkUuid;
    +            return this;
    +        }
    +
    +        public Builder nicFromDbUuid(String nicFromDbUuid) {
    +            this._nicFromDdUuid = nicFromDbUuid;
    +            return this;
    +        }
    +
    +        public Builder nicMacAddress(String nicMacAddress) {
    +            this._nicMacAddress = nicMacAddress;
    +            return this;
    +        }
    +
    +        public Builder nicIp4Address(String nicIp4Address) {
    +            this._nicIp4Address = nicIp4Address;
    +            return this;
    +        }
    +
    +        public Builder isL3Network(boolean isL3Network) {
    +            this._isL3Network = isL3Network;
    +            return this;
    +        }
    +
    +        public Builder isSharedNetwork(boolean isSharedNetwork) {
    +            this._isSharedNetwork = isSharedNetwork;
    +            return this;
    +        }
    +
    +        public Builder vpcUuid(String vpcUuid) {
    +            this._vpcUuid = vpcUuid;
    +            return this;
    +        }
    +
    +        public Builder networksDomainUuid(String networksDomainUuid) {
    +            this._networksDomainUuid = networksDomainUuid;
    +            return this;
    +        }
    +
    +        public Builder vmInstanceName(String vmInstanceName) {
    +            this._vmInstanceName = vmInstanceName;
    +            return this;
    +        }
    +
    +        public Builder vmUuid(String vmUuid) {
    +            this._vmUuid = vmUuid;
    +            return this;
    +        }
    +
    +        public Builder isExpungingState(boolean isExpungingState) {
    +            this._isExpungingState = isExpungingState;
    +            return this;
    +        }
    +
    +        @Override
    +        public DeallocateVmVspCommand build() {
    +            return new DeallocateVmVspCommand(_networkUuid,_nicFromDdUuid, _nicMacAddress,
_nicIp4Address, _isL3Network, _isSharedNetwork, _vpcUuid,
    +                    _networksDomainUuid, _vmInstanceName, _vmUuid, _isExpungingState);
    +        }
    +    }
    +
         @Override
         public boolean executeInSequence() {
             return false;
         }
     
    +    @Override
    +    public boolean equals(Object o) {
    --- End diff --
    
    Implemented <code>equals</code> method for the <code>Command</code>
super class, calling it from subclass.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message