cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Tue, 27 Oct 2015 08:18:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975940#comment-14975940
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43092950
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
    @@ -58,20 +73,117 @@ public String getVpcOrSubnetUuid() {
             return _vpcOrSubnetUuid;
         }
     
    -    public boolean isL3Network() {
    -        return _isL3Network;
    +    public String getNetworkName() {
    +        return _networkName;
    +    }
    +
    +    public boolean isL2Network() {
    +        return _isL2Network;
         }
     
         public List<Map<String, Object>> getAclRules() {
             return _aclRules;
         }
     
    -    public boolean isVpc() {
    -        return _isVpc;
    +    public long getNetworkId() {
    +        return _networkId;
         }
     
    -    public long getNetworkId() {
    -        return this._networkId;
    +    public boolean isEgressDefaultPolicy() {
    +        return _egressDefaultPolicy;
    +    }
    +
    +    public Boolean getAcsIngressAcl() {
    +        return _acsIngressAcl;
    +    }
    +
    +    public boolean isNetworkReset() {
    +        return _networkReset;
    +    }
    +
    +    public String getDomainTemplateName() {
    +        return _domainTemplateName;
    +    }
    +
    +    public static class Builder implements CmdBuilder<ApplyAclRuleVspCommand> {
    --- End diff --
    
    No, there shouldn't be any default values in my opinion.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message