cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Tue, 27 Oct 2015 07:48:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975899#comment-14975899
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43091431
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
    @@ -67,25 +74,76 @@
     import com.cloud.network.dao.PhysicalNetworkVO;
     import com.cloud.network.resource.NuageVspResource;
     import com.cloud.network.sync.NuageVspSync;
    +import com.cloud.network.vpc.VpcManager;
    +import com.cloud.network.vpc.VpcOffering;
    +import com.cloud.network.vpc.VpcOfferingServiceMapVO;
    +import com.cloud.network.vpc.VpcOfferingVO;
     import com.cloud.network.vpc.dao.VpcDao;
     import com.cloud.network.vpc.dao.VpcOfferingDao;
     import com.cloud.network.vpc.dao.VpcOfferingServiceMapDao;
    +import com.cloud.network.vpc.dao.VpcServiceMapDao;
    +import com.cloud.offering.NetworkOffering;
    +import com.cloud.offerings.NetworkOfferingServiceMapVO;
    +import com.cloud.offerings.NetworkOfferingVO;
    +import com.cloud.offerings.dao.NetworkOfferingDao;
    +import com.cloud.offerings.dao.NetworkOfferingServiceMapDao;
     import com.cloud.resource.ResourceManager;
     import com.cloud.resource.ResourceState;
     import com.cloud.resource.ServerResource;
    +import com.cloud.user.AccountManager;
    +import com.cloud.user.DomainManager;
     import com.cloud.utils.component.ManagerBase;
    +import com.cloud.utils.db.DB;
     import com.cloud.utils.db.Transaction;
     import com.cloud.utils.db.TransactionCallback;
    +import com.cloud.utils.db.TransactionCallbackNoReturn;
     import com.cloud.utils.db.TransactionStatus;
     import com.cloud.utils.exception.CloudRuntimeException;
    +import com.cloud.utils.fsm.StateListener;
    +import com.cloud.utils.fsm.StateMachine2;
    +import com.google.common.base.MoreObjects;
    +import com.google.common.base.Strings;
    +import com.google.common.collect.Maps;
    +import com.google.common.collect.Sets;
    +import net.nuage.vsp.acs.NuageVspPluginClientLoader;
    +import org.apache.cloudstack.framework.config.ConfigKey;
    +import org.apache.cloudstack.framework.config.Configurable;
    +import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
    +import org.apache.cloudstack.framework.config.impl.ConfigurationVO;
    +import org.apache.cloudstack.framework.messagebus.MessageBus;
    +import org.apache.cloudstack.framework.messagebus.MessageSubscriber;
    +import org.apache.cloudstack.network.ExternalNetworkDeviceManager;
    +import org.apache.commons.codec.binary.Base64;
    +import org.apache.commons.collections.CollectionUtils;
    +import org.apache.log4j.Logger;
    +
    +import javax.ejb.Local;
    +import javax.inject.Inject;
    +import javax.naming.ConfigurationException;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +import java.util.StringTokenizer;
    +import java.util.UUID;
    +import java.util.concurrent.ScheduledExecutorService;
    +
    +import static com.cloud.agent.api.sync.SyncNuageVspCmsIdCommand.SyncType;
     
     @Local(value = {NuageVspManager.class})
    -public class NuageVspManagerImpl extends ManagerBase implements NuageVspManager, Configurable
{
    +public class NuageVspManagerImpl extends ManagerBase implements NuageVspManager, Configurable,
StateListener<Status, Status.Event, Host> {
     
         private static final Logger s_logger = Logger.getLogger(NuageVspManagerImpl.class);
     
         private static final int ONE_MINUTE_MULTIPLIER = 60 * 1000;
     
    +    private static final Set<Network.Provider> NUAGE_VSP_PROVIDERS;
    +    private static final Map<Network.Service, Set<Network.Provider>> NUAGE_VSP_VPC_SERVICE_MAP;
    +    private static final ConfigKey[] NUAGE_VSP_CONFIG_KEYS = new ConfigKey<?>[]
{ NuageVspConfigDns, NuageVspDnsExternal, NuageVspConfigGateway,
    --- End diff --
    
    Returning a copy of the array instead of the array itself now.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message