cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Wed, 14 Oct 2015 13:08:06 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956888#comment-14956888
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41990174
  
    --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java
---
    @@ -21,24 +21,22 @@
     
     import java.util.Collection;
     import java.util.List;
    -import java.util.Map;
     
     public interface NuageVspGuruClient {
     
    -    public void implement(String networkDomainName, String networkDomainPath, String
networkDomainUuid, String networkAccountName, String networkAccountUuid, String networkName,
    -            String networkCidr, String networkGateway, String networkUuid, boolean isL3Network,
String vpcName, String vpcUuid, boolean defaultEgressPolicy,
    -            Collection<String> ipAddressRange) throws Exception;
    +    void implement(String networkDomainName, String networkDomainPath, String networkDomainUuid,
String networkAccountName, String networkAccountUuid, String networkName,
    +                          String networkCidr, String networkGateway, Long networkAclId,
List<String> dnsServers, List<String> gatewaySystemIds, boolean isL3Network, boolean
isVpc, boolean isSharedNetwork,
    +                          String networkUuid, String vpcName, String vpcUuid, boolean
defaultEgressPolicy, Collection<String[]> ipAddressRange, String domainTemplateName)
throws Exception;
     
    -    public List<Map<String, String>> reserve(String nicUuid, String nicMacAddress,
String networkUuid, boolean isL3Network, String vpcUuid, String networkDomainUuid,
    -            String networksAccountUuid, boolean isDomainRouter, String domainRouterIp,
String vmInstanceName, String vmUuid) throws Exception;
    +    void reserve(String nicUuid, String nicMacAddress, String networkUuid, boolean isL3Network,
boolean isSharedNetwork, String vpcUuid, String networkDomainUuid,
    +                                             String networksAccountUuid, boolean isDomainRouter,
String domainRouterIp, String vmInstanceName, String vmUuid, boolean useStaticIp, String staticIp,
String staticNatIpUuid,
    +                                             String staticNatIpAddress, boolean isStaticNatIpAllocated,
boolean isOneToOneNat, String staticNatVlanUuid, String staticNatVlanGateway, String staticNatVlanNetmask)
throws Exception;
     
    -    public void release(String networkUuid, String vmUuid, String vmInstanceName) throws
Exception;
    +    void deallocate(String networkUuid, String nicFrmDdUuid, String nicMacAddress, String
nicIp4Address, boolean isL3Network, boolean isSharedNetwork,
    +                           String vpcUuid, String networksDomainUuid, String vmInstanceName,
String vmUuid, boolean isExpungingState) throws Exception;
     
    -    public void deallocate(String networkUuid, String nicFrmDdUuid, String nicMacAddress,
String nicIp4Address, boolean isL3Network, String vpcUuid, String networksDomainUuid,
    -            String vmInstanceName, String vmUuid) throws Exception;
    +    void trash(String domainUuid, String networkUuid, boolean isL3Network, boolean isSharedNetwork,
String vpcUuid, String domainTemplateName) throws Exception;
    --- End diff --
    
    This is how the methods are declared in our client. They need to have the same signature
as defined in our client.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message