cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Wed, 14 Oct 2015 13:08:06 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956884#comment-14956884
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41990154
  
    --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java
---
    @@ -24,13 +24,18 @@
     
     public interface NuageVspElementClient {
     
    -    public void applyStaticNats(String networkDomainUuid, String vpcOrSubnetUuid, boolean
isL3Network, List<Map<String, Object>> staticNatDetails) throws Exception;
    +    boolean implement(long networkId, String networkDomainUuid, String networkUuid, String
networkName, String vpcOrSubnetUuid, boolean isL2Network, boolean isL3Network,
    +                             boolean isVpc, boolean isShared, String domainTemplateName,
boolean isFirewallServiceSupported, List<String> dnsServers, List<Map<String,
Object>> ingressFirewallRules,
    +                             List<Map<String, Object>> egressFirewallRules,
List<String> acsFipUuid, boolean egressDefaultPolicy) throws Exception;
     
    -    public void applyAclRules(String networkUuid, String networkDomainUuid, String vpcOrSubnetUuid,
boolean isL3Network, List<Map<String, Object>> aclRules, boolean isVpc, long networkId)
    -            throws Exception;
    +    void applyStaticNats(String networkDomainUuid, String networkUuid, String vpcOrSubnetUuid,
boolean isL3Network, boolean isVpc,
    +                                List<Map<String, Object>> staticNatDetails)
throws Exception;
     
    -    public void shutDownVpc(String domainUuid, String vpcUuid) throws Exception;
    +    void applyAclRules(boolean isNetworkAcl, String networkUuid, String networkDomainUuid,
String vpcOrSubnetUuid, String networkName, boolean isL2Network,
    +                              List<Map<String, Object>> rules, long networkId,
boolean egressDefaultPolicy, Boolean isAcsIngressAcl, boolean networkReset, String domainTemplateName)
throws Exception;
    --- End diff --
    
    This is how the methods are declared in our client. They need to have the same signature
as defined in our client.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message